Skip to content

fix(map_entry): don't autofix when {e.insert(_); None } would be required #15810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(map_entry): don't autofix when {e.insert(_); None } would be required #15810

wants to merge 2 commits into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 3, 2025 •
edited
Loading

Fixes #15307
Alternative to #15808, implements the suggestion in #15808 (comment)

changelog: [map_entry]: don't autofix when {e.insert(_); None } would be required

r? @Jarcho @samueltardieu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot assigned Jarcho and unassigned y21 Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jarcho Jarcho

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to correctly apply fixes for clippy::map_entry
4 participants
@ada4a @rustbot @Jarcho @y21